NETOBSERV-1965: UDN mappnig APi changes #967

msherif1234 · 2024-12-19T17:35:49Z

Description

Dependencies

Agent: NETOBSERV-1965: Initial intg with UDN interface mapping api netobserv-ebpf-agent#487
FLP: NETOBSERV-1965: udn mapping agent pkg update flowlogs-pipeline#781

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

msherif1234 · 2024-12-19T17:36:03Z

/ok-to-test

github-actions · 2024-12-19T17:40:34Z

New images:

quay.io/netobserv/network-observability-operator:8923b2a
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8923b2a
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8923b2a

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:8923b2a make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8923b2a

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8923b2a
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

codecov · 2025-01-03T15:31:42Z

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.45%. Comparing base (a93f77a) to head (219211b).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/ebpf/agent_controller.go	12.50%	5 Missing and 2 partials ⚠️
...lector/v1beta2/flowcollector_validation_webhook.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   62.47%   62.45%   -0.03%     
==========================================
  Files          77       77              
  Lines       11496    11508      +12     
==========================================
+ Hits         7182     7187       +5     
- Misses       3862     3867       +5     
- Partials      452      454       +2

Flag	Coverage Δ
unittests	`62.45% <23.07%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
apis/flowcollector/v1beta1/flowcollector_types.go	`100.00% <ø> (ø)`
apis/flowcollector/v1beta2/flowcollector_types.go	`100.00% <ø> (ø)`
pkg/helper/flowcollector.go	`82.37% <100.00%> (+0.12%)`	⬆️
...lector/v1beta2/flowcollector_validation_webhook.go	`54.02% <0.00%> (-0.95%)`	⬇️
controllers/ebpf/agent_controller.go	`46.50% <12.50%> (-0.39%)`	⬇️

... and 2 files with indirect coverage changes

openshift-ci-robot · 2025-01-06T16:41:11Z

msherif1234 · 2025-01-13T18:09:45Z

/ok-to-test

github-actions · 2025-01-13T18:14:59Z

New images:

quay.io/netobserv/network-observability-operator:1070d7a
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-1070d7a
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-1070d7a

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:1070d7a make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-1070d7a

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-1070d7a
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2025-01-14T14:35:19Z

/ok-to-test

github-actions · 2025-01-14T14:40:31Z

New images:

quay.io/netobserv/network-observability-operator:e18ca36
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e18ca36
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e18ca36

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e18ca36 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e18ca36

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e18ca36
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

openshift-ci-robot · 2025-01-17T11:21:13Z

jotak · 2025-01-17T11:55:41Z

apis/flowcollector/v1beta1/flowcollector_types.go

@@ -154,7 +154,8 @@ type FlowCollectorIPFIX struct {
 // - `NetworkEvents`, to track Network events.<br>
 // - `PacketTranslation`, to enrich flows with packets translation information. <br>
 // - `EbpfManager`, to enable using EBPF Manager to manage netobserv ebpf programs [Developer Preview].<br>
-// +kubebuilder:validation:Enum:="PacketDrop";"DNSTracking";"FlowRTT";"NetworkEvents";"PacketTranslation";"EbpfManager"
+// - `UDNMapping`, to enable interfaces mappind to udn. <br>


please mention [Developer Preview]

jotak · 2025-01-17T11:56:17Z

apis/flowcollector/v1beta2/flowcollector_types.go

@@ -177,7 +177,8 @@ type FlowCollectorIPFIX struct {
 // - `NetworkEvents`, to track Network events [Developer Preview].<br>
 // - `PacketTranslation`, to enrich flows with packets translation information. <br>
 // - `EbpfManager`, to enable using EBPF Manager to manage netobserv ebpf programs [Developer Preview].<br>
-// +kubebuilder:validation:Enum:="PacketDrop";"DNSTracking";"FlowRTT";"NetworkEvents";"PacketTranslation";"EbpfManager"
+// - `UDNMapping`, to enable interfaces mappind to udn. <br>


please mention [Developer Preview]

jotak · 2025-01-17T11:56:37Z

apis/flowcollector/v1beta2/flowcollector_types.go

@@ -384,6 +386,7 @@ type FlowCollectorEBPF struct {
 	// - `PacketTranslation`: enable enriching flows with packet's translation information. <br>
 	// - `EbpfManager`: allow using eBPF manager to manage netobserv ebpf programs. <br>
 	// IMPORTANT: This feature is available as a Developer Preview.<br>
+	// - `UDNMapping`, to enable interfaces mappind to udn. <br>


Like above:

// IMPORTANT: This feature is available as a Developer Preview.<br>

Also, like for NetworkEvents we mention It requires using the OVN-Kubernetes network plugin with the Observability feature. => we should tell something similar

jotak · 2025-01-17T11:59:09Z

controllers/consoleplugin/config/static-frontend-config.yaml

@@ -437,6 +437,13 @@ columns:
    filter: ifdirections
    default: false
    width: 10
+  - id: Udns
+    name: interface assigned UDN label


Could it be simply named "UDN name" ? Or "UDN label", if "name" isn't accurate ? Just trying to get a more user friendly name for the column.

Or does "interface assigned" actually convey important information that must be mentioned ?

UDN Labels is fine

jotak

thanks
/lgtm

msherif1234 · 2025-01-20T14:58:41Z

/ok-to-test

github-actions · 2025-01-20T15:03:51Z

New images:

quay.io/netobserv/network-observability-operator:4e6f0f1
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4e6f0f1
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4e6f0f1

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:4e6f0f1 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4e6f0f1

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4e6f0f1
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2025-01-20T15:26:45Z

/ok-to-test

github-actions · 2025-01-20T15:31:47Z

New images:

quay.io/netobserv/network-observability-operator:ccddfe5
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ccddfe5
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ccddfe5

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:ccddfe5 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ccddfe5

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ccddfe5
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Signed-off-by: Mohamed Mahmoud <[email protected]>

msherif1234 · 2025-01-20T20:56:07Z

/ok-to-test

github-actions · 2025-01-20T21:00:48Z

New images:

quay.io/netobserv/network-observability-operator:356f756
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-356f756
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-356f756

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:356f756 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-356f756

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-356f756
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

jotak

/lgtm

msherif1234 · 2025-01-21T10:59:03Z

/approve

openshift-ci · 2025-01-21T10:59:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msherif1234]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

msherif1234 · 2025-01-21T11:05:11Z

/retest

openshift-ci · 2025-01-21T11:06:16Z

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-index-noo-bundle	`3b35fd6`	link	true	`/test ci-index-noo-bundle`
ci/prow/images	`3b35fd6`	link	true	`/test images`
ci/prow/e2e-operator	`3b35fd6`	link	false	`/test e2e-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress label Dec 19, 2024

msherif1234 marked this pull request as draft December 19, 2024 17:35

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 19, 2024

msherif1234 force-pushed the udn_mapping branch from 1b1f05e to 219211b Compare January 3, 2025 15:26

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 3, 2025

msherif1234 marked this pull request as ready for review January 6, 2025 16:40

msherif1234 changed the title ~~WIP: UDN mappnig PoC~~ NETOBSERV-1965: UDN mappnig PoC Jan 6, 2025

openshift-ci bot removed the do-not-merge/work-in-progress label Jan 6, 2025

openshift-ci-robot added the jira/valid-reference label Jan 6, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 13, 2025

msherif1234 force-pushed the udn_mapping branch from 219211b to e831a4f Compare January 14, 2025 14:34

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 14, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 14, 2025

msherif1234 changed the title ~~NETOBSERV-1965: UDN mappnig PoC~~ NETOBSERV-1965: UDN mappnig APi changes Jan 16, 2025

jotak mentioned this pull request Jan 17, 2025

NETOBSERV-1965: Initial intg with UDN interface mapping api netobserv/netobserv-ebpf-agent#487

Merged

11 tasks

jotak mentioned this pull request Jan 17, 2025

NETOBSERV-1965: udn mapping agent pkg update netobserv/flowlogs-pipeline#781

Merged

11 tasks

jotak reviewed Jan 17, 2025

View reviewed changes

msherif1234 force-pushed the udn_mapping branch from e831a4f to 80133ee Compare January 18, 2025 13:29

jotak approved these changes Jan 20, 2025

View reviewed changes

openshift-ci bot assigned jotak Jan 20, 2025

openshift-ci bot added the lgtm label Jan 20, 2025

msherif1234 force-pushed the udn_mapping branch from 80133ee to 0eebb0b Compare January 20, 2025 14:58

openshift-ci bot removed the lgtm label Jan 20, 2025

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

msherif1234 requested a review from jotak January 20, 2025 14:59

msherif1234 force-pushed the udn_mapping branch from 0eebb0b to cd73f2a Compare January 20, 2025 15:25

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

UDN mappning feature APIs support

3b35fd6

Signed-off-by: Mohamed Mahmoud <[email protected]>

msherif1234 force-pushed the udn_mapping branch from cd73f2a to 3b35fd6 Compare January 20, 2025 20:55

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2025

jotak approved these changes Jan 21, 2025

View reviewed changes

openshift-ci bot added the lgtm label Jan 21, 2025

openshift-ci bot added the approved label Jan 21, 2025

msherif1234 merged commit 4ca7fb9 into netobserv:main Jan 21, 2025
11 of 15 checks passed

msherif1234 deleted the udn_mapping branch January 21, 2025 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1965: UDN mappnig APi changes #967

NETOBSERV-1965: UDN mappnig APi changes #967

msherif1234 commented Dec 19, 2024 •

edited by jotak

Loading

msherif1234 commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

codecov bot commented Jan 3, 2025 •

edited

Loading

openshift-ci-robot commented Jan 6, 2025 •

edited by openshift-ci bot

Loading

Description

Dependencies

Checklist

msherif1234 commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

msherif1234 commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

openshift-ci-robot commented Jan 17, 2025 •

edited by openshift-ci bot

Loading

Description

Dependencies

Checklist

jotak Jan 17, 2025

jotak Jan 17, 2025

jotak Jan 17, 2025

jotak Jan 17, 2025

jotak Jan 17, 2025 •

edited

Loading

msherif1234 Jan 18, 2025

jotak left a comment

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

jotak left a comment

msherif1234 commented Jan 21, 2025

openshift-ci bot commented Jan 21, 2025

msherif1234 commented Jan 21, 2025

openshift-ci bot commented Jan 21, 2025

NETOBSERV-1965: UDN mappnig APi changes #967

NETOBSERV-1965: UDN mappnig APi changes #967

Conversation

msherif1234 commented Dec 19, 2024 • edited by jotak Loading

Description

Dependencies

Checklist

msherif1234 commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

codecov bot commented Jan 3, 2025 • edited Loading

Codecov Report

openshift-ci-robot commented Jan 6, 2025 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

msherif1234 commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

msherif1234 commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

openshift-ci-robot commented Jan 17, 2025 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

jotak Jan 17, 2025

Choose a reason for hiding this comment

jotak Jan 17, 2025

Choose a reason for hiding this comment

jotak Jan 17, 2025

Choose a reason for hiding this comment

jotak Jan 17, 2025

Choose a reason for hiding this comment

jotak Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

msherif1234 Jan 18, 2025

Choose a reason for hiding this comment

jotak left a comment

Choose a reason for hiding this comment

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

msherif1234 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

jotak left a comment

Choose a reason for hiding this comment

msherif1234 commented Jan 21, 2025

openshift-ci bot commented Jan 21, 2025

msherif1234 commented Jan 21, 2025

openshift-ci bot commented Jan 21, 2025

msherif1234 commented Dec 19, 2024 •

edited by jotak

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading

openshift-ci-robot commented Jan 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 17, 2025 •

edited by openshift-ci bot

Loading

jotak Jan 17, 2025 •

edited

Loading