Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: parseServices() and parseService() renamed to ??? [WIP] #112

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Compiler: parseServices() and parseService() renamed to ??? [WIP] #112

merged 1 commit into from
Jun 17, 2016

Conversation

dg
Copy link
Member

@dg dg commented May 22, 2016 •
edited
Loading

It is named parseServices, because it parses 'service' in config, but it is public method and therefore should have more descriptive names. addDefinitions()? loadDefinitions()? loadDefinitionsFromConfig()?

@dg dg force-pushed the parse-services branch from 2b1c152 to 60769de Compare May 22, 2016 23:44
@dg dg force-pushed the parse-services branch from 60769de to 7b9e115 Compare May 22, 2016 23:49
@dg dg force-pushed the parse-services branch from 7b9e115 to 617d88d Compare May 23, 2016 02:37
@dg dg force-pushed the parse-services branch from 617d88d to bcfb7ca Compare May 23, 2016 09:24
@dg dg force-pushed the parse-services branch from bcfb7ca to 6ef9652 Compare June 7, 2016 14:39
@dg dg force-pushed the parse-services branch from 6ef9652 to 97b3530 Compare June 7, 2016 15:09
@f3l1x
Copy link
Member

f3l1x commented Jun 17, 2016

I like loadDefinitions().

@dg dg force-pushed the parse-services branch from 97b3530 to 71e06df Compare June 17, 2016 18:09
@dg
Copy link
Member Author

dg commented Jun 17, 2016

@f3l1x ok

@dg dg merged commit 34f8df4 into nette:master Jun 17, 2016
@dg dg deleted the parse-services branch June 17, 2016 18:10
dg added a commit that referenced this pull request Jun 17, 2016
@dg
Compiler: parseServices() and parseService() renamed to loadDefinitio…
6376a8e 
…n() and loadDefinitions() (#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg @f3l1x