-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several build issues for JDK 16 #651
Conversation
- Needed to bump minimum source/target versions for compiler (1.6 no longer supported). - Needed to bump version of japicmp which fixes siom79/japicmp#275 for JDK 16. - Needed to adjust apr path for brew dependency on Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alexbudgh !
@alexbudgh as we don't release versions of
|
Bah, I think there's a regression in the newer versions of japicmp:
They aren't checking for ignoreMissingArtifact like they do in other cases before throwing:
We are already setting
But it's not being honored... Edit: looks like someone already reported it: siom79/japicmp#288 |
Sent a PR to japicmp: siom79/japicmp#290 which seems to fix this issue for us. |
FYI japicmp 0.15.4 includes the fix for the above issue. I was able to build in java 17 with it. |
This is replaced by #693 |
longer supported).
Error running japicmp-maven-plugin:0.14.4:cmp on Java 16-EA siom79/japicmp#275 for JDK 16.