Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several build issues for JDK 16 #651

Closed
wants to merge 1 commit into from
Closed

Conversation

alexbudgh
Copy link

- Needed to bump minimum source/target versions for compiler (1.6 no
  longer supported).
- Needed to bump version of japicmp which fixes
  siom79/japicmp#275 for JDK 16.
- Needed to adjust apr path for brew dependency on Mac.
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alexbudgh !

@normanmaurer
Copy link
Member

@alexbudgh as we don't release versions of netty-tcnative-openssl-static and netty-tcnative-libressl-static you may need to add some config:

[INFO] ------------------------------------------------------------------------
30372
[INFO] Reactor Summary for Netty/TomcatNative [Parent] 2.0.40.Final-SNAPSHOT:
30373
[INFO] 
30374
[INFO] Netty/TomcatNative [Parent] ........................ SUCCESS [ 23.968 s]
30375
[INFO] Netty/TomcatNative [OpenSSL - Dynamic] ............. SUCCESS [ 29.081 s]
30376
[INFO] Netty/TomcatNative [OpenSSL - Static] .............. FAILURE [03:06 min]
30377
[INFO] Netty/TomcatNative [BoringSSL - Static] ............ SKIPPED
30378
[INFO] Netty/TomcatNative [LibreSSL - Static] ............. SKIPPED
30379
[INFO] ------------------------------------------------------------------------
30380
[INFO] BUILD FAILURE
30381
[INFO] ------------------------------------------------------------------------
30382
[INFO] Total time:  04:02 min
30383
[INFO] Finished at: 2021-06-18T09:47:23Z
30384
[INFO] ------------------------------------------------------------------------
30385
Error:  Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.3:cmp (default) on project netty-tcnative-openssl-static: Could not find previous version for artifact: io.netty:netty-tcnative-openssl-static -> [Help 1]
30386
Error:  
30387
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
30388
Error:  Re-run Maven using the -X switch to enable full debug logging.
30389
Error:  
30390
Error:  For more information about the errors and possible solutions, please read the following articles:
30391
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
30392
Error:  
30393
Error:  After correcting the problems, you can resume the build with the command
30394
Error:    mvn <args> -rf :netty-tcnative-openssl-static
30395
Error: Process completed with exit code 1.

@alexbudgh
Copy link
Author

alexbudgh commented Jun 18, 2021

Bah, I think there's a regression in the newer versions of japicmp:

			} else {
				throw new MojoFailureException("Could not find previous version for artifact: " + artifactVersionRange.getGroupId() + ":"
					+ artifactVersionRange.getArtifactId());
			}

They aren't checking for ignoreMissingArtifact like they do in other cases before throwing:

				if (ignoreMissingArtifact(pluginParameters, configurationVersion)) {
					getLog().warn("Could not find file, but ignoreMissingOldVersion is set tot true: " + file.getAbsolutePath());
				} else {
					throw new MojoFailureException("File '" + file.getAbsolutePath() + "' does not exist.");
				}

We are already setting

% grep -rn ignoreMissingOldVersion . --include "*.xml"
./pom.xml:236:            <ignoreMissingOldVersion>true</ignoreMissingOldVersion>

But it's not being honored...

Edit: looks like someone already reported it: siom79/japicmp#288

@alexbudgh
Copy link
Author

Sent a PR to japicmp: siom79/japicmp#290 which seems to fix this issue for us.

@pmioulet
Copy link

FYI japicmp 0.15.4 includes the fix for the above issue. I was able to build in java 17 with it.

@normanmaurer
Copy link
Member

This is replaced by #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants