Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making contributions should be easier #7578

Closed
asarkar opened this issue Jan 14, 2018 · 2 comments
Closed

Making contributions should be easier #7578

asarkar opened this issue Jan 14, 2018 · 2 comments
Assignees
@normanmaurer
Labels
improvement
Milestone
4.0.56.Final

Comments

@asarkar
Copy link
Contributor

asarkar commented Jan 14, 2018 •
edited by Scottmitch
Loading

Expected behavior

Someone intending to contribute should be able to set up their development environment quickly and easily.

Actual behavior

Development environment setup requires several manual steps:

  • Local Maven installation is required.
  • Git line-ending manual configuration is required.
This was referenced Jan 14, 2018
Closed
Closed
Closed
@Scottmitch
Copy link
Member

Were the docs not clear/complete/correct, and was there any place that was particularly challenging. Do you have any suggestions on how to improve this process?

normanmaurer pushed a commit that referenced this issue Jan 26, 2018
@normanmaurer
Include mvn wrapper to make setup of development env easier
141b674 
Motivation:
Someone intending to contribute should be able to set up their development environment quickly and easily.

Modifications:
- Added a Maven wrapper such that a local Maven installation isn't necessary.
- Added a .gitattributes such that auto line-endings are enforced.

Result:
- ./mvnw is enough to build.
- Git line-endings are enforced.
- Fixes #7578.
@normanmaurer normanmaurer self-assigned this Jan 26, 2018
@normanmaurer normanmaurer added this to the 4.0.56.Final milestone Jan 26, 2018
@normanmaurer
Copy link
Member

Fixed by #7579

kiril-me pushed a commit to kiril-me/netty that referenced this issue Feb 28, 2018
@kiril-me
Include mvn wrapper to make setup of development env easier
c7d1f63 
Motivation:
Someone intending to contribute should be able to set up their development environment quickly and easily.

Modifications:
- Added a Maven wrapper such that a local Maven installation isn't necessary.
- Added a .gitattributes such that auto line-endings are enforced.

Result:
- ./mvnw is enough to build.
- Git line-endings are enforced.
- Fixes netty#7578.
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
@normanmaurer
Include mvn wrapper to make setup of development env easier
f1d87f0 
Motivation:
Someone intending to contribute should be able to set up their development environment quickly and easily.

Modifications:
- Added a Maven wrapper such that a local Maven installation isn't necessary.
- Added a .gitattributes such that auto line-endings are enforced.

Result:
- ./mvnw is enough to build.
- Git line-endings are enforced.
- Fixes netty#7578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
improvement
Projects
None yet
Milestone
4.0.56.Final
Development

No branches or pull requests
3 participants
@normanmaurer @asarkar @Scottmitch