Remove duplicated IPAM code for NSE applications #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszirtes
force-pushed
the
remove-duplicated-ipam-code
branch
from
a3abb3a to
1c97fb0
Compare
denis-tingaikin
approved these changes
Mar 22, 2024
main.go
Outdated
| @@ -1,6 +1,8 @@ | |||
| // Copyright (c) 2021-2022 Doc.ai and/or its affiliates. | |||
| // Copyright (c) 2021-2024 Doc.ai and/or its affiliates. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2021-2024 Doc.ai and/or its affiliates. | |
| // Copyright (c) 2021-2022 Doc.ai and/or its affiliates. |
main.go
Outdated
| // | ||
| // Copyright (c) 2023 Cisco and/or its affiliates. | ||
| // Copyright (c) 2023-2024 Cisco and/or its affiliates. |
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2023-2024 Cisco and/or its affiliates. | |
| // Copyright (c) 2023 Cisco and/or its affiliates. |
There was a problem hiding this comment.
Thank you, I updated it.
NSM issue link: networkservicemesh/sdk#1409 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
force-pushed
the
remove-duplicated-ipam-code
branch
from
1c97fb0 to
6ccc85c
Compare
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 16, 2024
…d-nse-icmp-responder-vpp@main PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#651 Commit: 6e0c325 Author: Denis Tingaikin Date: 2024-04-16 15:45:37 +0300 Message: - Merge pull request #651 from Nordix/remove-duplicated-ipam-code Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSM issue link: networkservicemesh/sdk#1409