Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the to-local.sh script to handle the version tags like <version>-<rc.number> #8883

Closed
ljkiraly opened this issue Mar 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ljkiraly
Copy link
Contributor

Expected Behavior

The to-local.sh script should produce proper output on a release branch (e.g v1.8.0-rc.1).

Current Behavior

Currently the translation to local paths is done but with wrong content.

Failure Information (for bugs)

Reference: https://github.com/networkservicemesh/deployments-k8s/examples/basic?ref=v1.8.0-rc.1 is changed to : <localdir>/networkservicemesh/deployments-k8s/examples/basic-rc.1

Steps to Reproduce

  1. git checkout v1.8.0-rc.1
  2. ./to-local.sh
  3. git diff | head -10

diff --git a/examples/basic/README.md b/examples/basic/README.md
index f8a272df3b9..20c0794f4d7 100644
--- a/examples/basic/README.md
+++ b/examples/basic/README.md
@@ -26,7 +26,7 @@ Contain basic setup for NSM that includes `nsmgr`, `forwarder-vpp`, `registry-k8
 Apply NSM resources for basic tests:
 
 ```bash
-kubectl apply -k https://github.com/networkservicemesh/deployments-k8s/examples/basic?ref=v1.8.0-rc.1
+kubectl apply -k ../../../../../../../../../../../home/ljkiraly/work/code/src/github.com/networkservicemesh/deployments-k8s/examples/basic-rc.1
@ljkiraly ljkiraly added the bug Something isn't working label Mar 16, 2023
@ljkiraly ljkiraly self-assigned this Mar 16, 2023
ljkiraly added a commit to Nordix/nsm-deployments-k8s that referenced this issue Mar 16, 2023
ljkiraly added a commit to Nordix/nsm-deployments-k8s that referenced this issue Feb 10, 2025
ljkiraly added a commit that referenced this issue Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant