Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine configure --enable-inplace-runtime and CONFIG_FLAGS support #1826

Closed
5 tasks done
jimklimov opened this issue Jan 19, 2023 · 0 comments · Fixed by #1835
Closed
5 tasks done

Refine configure --enable-inplace-runtime and CONFIG_FLAGS support #1826

jimklimov opened this issue Jan 19, 2023 · 0 comments · Fixed by #1835
Labels
enhancement packaging
Milestone
2.8.1

Comments

@jimklimov
Copy link
Member

jimklimov commented Jan 19, 2023 •
edited
Loading

Follow-up from #1709

  • Avoid saving the --disable-runtime-support flag (especially as used by configure itself to re-enter)
  • Avoid saving (duplicate at least) --enable-runtime-support flag(s)
  • Save NUT config report file (if retained) as a /usr/share/nut/... artifact; maybe create and keep a JSON copy to use in later rebuilds?
  • Report NUT version the config was inherited from, if possible (e.g. runnable tools exist and tell)
  • When reporting built-in details (upsd -DV etc.) avoid upsdebugx->vupslog limit of LARGEBUF (use direct sprintf? custom larger/dynamic vupslog?) Example string from PowerWalker VI 3000 RT HID  #1824 is truncated mid-word probably due to the buffer-size limit (which in turn stems from SYSLOG limits - earlier RFC 3164 says 1Kb max, modern implementations can have it configurable). Note the primary use-case is about "inplace rebuilds" (maybe always-delivering a libupsclient-config, or using the JSON version of config report or similar artifact is a better solution for many situations), and helping diagnose run-time deployments as people copy-paste their logs.
@jimklimov jimklimov added this to the 2.8.1 milestone Jan 21, 2023
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
lib/libupsclient-config.in: comment that NUT_VERSION_MACRO in binarie…
719350a 
…s may differ from PACKAGE_VERSION in the script [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: do not track in CONFIG_FLAGS that we --disable-runtime-…
630f0d1 
…support, and only track once that we --enable-runtime-support [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
Refactor nut_report_config_flags() from many programs into common.c [n…
4d64fa0 
…etworkupstools#1826, networkupstools#1709]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
Refactor nut_report_config_flags() from many programs into common.c [n…
79628b7 
…etworkupstools#1826, networkupstools#1709] - bump libs version-info
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
common/common.c: refactor nut_report_config_flags() to allow for long…
cd085c1 
…er option lists for purposes of "configure --enable-inplace-runtime" [networkupstools#1826]
@jimklimov jimklimov mentioned this issue Jan 21, 2023
Merged
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: track NUT_VERSION_DEPLOYED which we inherit from with -…
0b8030e 
…-enable-inplace-runtime [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: report determining CONFIG_FLAGS [networkupstools#1709, n…
5da20d2 
…etworkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: typo fix for CONFIG_FLAGS [networkupstools#1826]
d514064
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: do not pollute "SBINDIR" variable with tests for nut_en…
236ba23 
…able_inplace_runtime, try PATH beside PREFIX, and generalize to try upsc if upsd is not found [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 21, 2023
@jimklimov
configure.ac: set --prefix, --sbindir or --bindir into CONFIG_FLAGS a…
d971f33 
…ccording to older binaries found (if not provided otherwise) [networkupstools#1826, networkupstools#1709]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
m4/nut_report_feature.m4: standardize indentation, more M4 AS_IFs [ne…
863f2fc 
…tworkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
m4/nut_report_feature.m4, Makefile.am: install config.nut_report_feat…
a1dacb2 
…ure.log if kept [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
configure.ac: NUT_REPORT() the PACKAGE_VERSION (and GITREV if any) va…
4c1cef9 
…lid at the time of configure run [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
docs/configure.txt: document --enable-keep_nut_report_feature and tha…
9744922 
…t the file can be installed [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
UPGRADING: document --enable-keep_nut_report_feature and that the fil…
e6912da 
…e can be installed [networkupstools#1826, networkupstools#1708]
@jimklimov jimklimov mentioned this issue Jan 22, 2023
Merged
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 22, 2023
@jimklimov
configure.ac, m4/nut_report_feature.m4: move KEEP_NUT_REPORT definiti…
f14bbcf 
…on to before AC_OUTPUT [networkupstools#1826]
jimklimov added a commit to jimklimov/nut that referenced this issue Feb 6, 2023
@jimklimov
INSTALL.nut: update with "in-place" rebuilds chapter [networkupstools…
b5a57fe 
…#1826]
jimklimov added a commit that referenced this issue Feb 6, 2023
@jimklimov
Merge pull request #1845 from jimklimov/install-systemd
46f5c7c 
INSTALL.nut: update with "in-place" rebuilds chapter [#1826]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement packaging
Projects
None yet
Milestone
2.8.1
Development

Successfully merging a pull request may close this issue.

Deliver the NUT configuration report (if "kept") jimklimov/nut
1 participant
@jimklimov