Announce NUT_NETVERSION=1.3 #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquette
approved these changes
Mar 23, 2022
clepple
reviewed
Mar 24, 2022
|
I might have missed those thoughts in older context, so would try a guess:
should they be integer numbers? :)
I don't have a strong opinion here since NUT code itself does not make use
of the version (string?) AFAIK. But numbers would compare more easily :)
…On Thu, Mar 24, 2022, 02:43 Charles Lepple ***@***.***> wrote:
***@***.**** commented on this pull request.
You know my thoughts on numeric protocol versions.
The other parts of the PR look fine.
—
Reply to this email directly, view it on GitHub
<#1336 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMPTFALUOP4YCFPEFMKG6DVBPCDTANCNFSM5RNIHR7A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If two network protocol upgrades are being discussed, and both branches in Git propose an incremented protocol version, one will have to be updated a second time to avoid a conflict if both are not merged at the same time. It seems like very little gain for a lot of maintenance burden. (And that's if Other protocols have text-based "feature flags" where they indicate a set of features that are supported. In all of the previous NUT protocol iterations, a client could simply try a new command, and check for an appropriate "ERR" response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
configure.acto report the new version innetmisc.c, and update docs that referred to "2.7.5" as the new release to speak about "2.8.0" which sings to similar tune as #1263.Also documents
PRIMARYcommand as alias toMASTER(per #840) in protocol 1.3, although the practical implementation is expected to be compatible with protocol 1.2 client/server (see #1328).CC @NUT-RogerPrice