Test for and fix status_set("ALARM"); update code and docs on correct Numeric format usage
#2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some drivers do for readability [networkupstools#2801, networkupstools#2708] Signed-off-by: Jim Klimov <[email protected]>
…s may still appear twice [networkupstools#2801, networkupstools#2708] Signed-off-by: Jim Klimov <[email protected]>
… #ifdef DEBUG not #if 0 [networkupstools#2801] Signed-off-by: Jim Klimov <[email protected]>
… would not appear twice: delay status_set("ALARM") effect and make it reasonable [networkupstools#2801, networkupstools#2708]
Signed-off-by: Jim Klimov <[email protected]>
…RM") cases to set the ups.status token [networkupstools#2801, networkupstools#2708] Signed-off-by: Jim Klimov <[email protected]>
…") cases to automatically alarm_commit() if the injected value is all the alarm we have [networkupstools#2801, networkupstools#2708] Signed-off-by: Jim Klimov <[email protected]>
…to convey date/time [networkupstools#2807] Signed-off-by: Jim Klimov <[email protected]>
… in NUT reported variables [networkupstools#2807] Signed-off-by: Jim Klimov <[email protected]>
…om "%g" to "%f" to match NUT naming spec [networkupstools#2807] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
bug
enhancement
documentation
NUT protocols
portability
jimklimov
added
the
refactor/fightwarn
…us_set("ALARM") and later proper alarm_set(), report only the content provided by the latter [networkupstools#2801, networkupstools#2708]
Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
issue-2708-spaces
branch
from
db1d4dd to
44a3f26
Compare
… not status_set() nonstandard values [networkupstools#2708] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
issue-2708-spaces
branch
from
44a3f26 to
667d257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on status vs. alarms follows up from PR #2801 for issue #2708 : I've followed up on
status_commit()unilaterally prependingALARMto theups.statusstring - and indeed, duplicates were possible in this manner (if someone wouldstatus_set("ALARM")during the cycle; notably noups.alarmvalue got assigned in such use-case but an ALARM status became present). The series of commits confirm the existing (buggy) status-quo in unit-tests, then fix it (and the tests) to assign an alarm value"[N/A]"if none other is set yet, and expose it when westatus_commit().While in-tree drivers should not do
status_set("ALARM"), currently thedrivers/mge-utalk.cactually has a hit for that situation. This fix is primarily for the benefit of sane(r) behavior of any drivers coded in forks of NUT and not yet upstreamed, as well as for any use-cases harder to track down than grepping for this command string (crafted via mapping tables or resource files like DMF eventually).Formatting spec originated from discussion in #2807