Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue #48: make HCL legend always visible #49

Merged
merged 2 commits into from
Sep 8, 2013

Conversation

zykh
Copy link
Contributor

@zykh zykh commented Aug 28, 2013

Make legend always visible.
Improve CSS readability.

zykh added 2 commits August 28, 2013 23:17
Move legend out of filters' block. (HTML+CSS)
@clepple
Copy link
Member

clepple commented Aug 29, 2013

I'm trying to test this locally (if I push it to a separate branch on our main GitHub repository, GitHub auto-closes this pull request) but the layout looks wonky. I also get a bunch of broken image links, but that might have been a local Asciidoc misconfiguration.

Can you attach a screenshot of how your browser renders this change?

@clepple
Copy link
Member

clepple commented Aug 29, 2013

(I'm fine with the "Improve CSS readability" patch. CSS is nearly unreadable to me anyway, so I usually look at it in a DOM tree viewer.)

@zykh
Copy link
Contributor Author

zykh commented Aug 29, 2013

@aquette
Copy link
Member

aquette commented Sep 6, 2013

Daniele

Thanks for your patch!
@zykh: Could you please also test it with w3m or similar:
We use this for testing the website accessibility, including for the HCL.

Cheers
Arno
(sent from my S3... please excuse my brevity)
Le 29 août 2013 13:46, "Daniele Pezzini" [email protected] a
écrit :

https://docs.google.com/file/d/0BxWv_9cok7BKclBwbmpzeGkzQlE/edit?usp=sharing


Reply to this email directly or view it on GitHubhttps://github.com//pull/49#issuecomment-23483219
.

@zykh
Copy link
Contributor Author

zykh commented Sep 6, 2013

@aquette
Copy link
Member

aquette commented Sep 6, 2013

thanks Daniele!
seems good (i.e. no change), so ok for me.
@clepple: can you please handle the merge?

thanks and cheers to you both,

Arno

(sent from my eeePad... please excuse my brevity)
Le 6 sept. 2013 16:00, "Daniele Pezzini" [email protected] a
écrit :

w3m:
https://docs.google.com/file/d/0BxWv_9cok7BKNUlnX2tBamdTQVk/edit?usp=sharing


Reply to this email directly or view it on GitHubhttps://github.com//pull/49#issuecomment-23941664
.

@clepple clepple merged commit c3292d4 into networkupstools:master Sep 8, 2013
@zykh zykh deleted the issue48 branch November 23, 2013 20:39
jimklimov added a commit to jimklimov/nut that referenced this pull request May 9, 2016
Fix typo on the replace_battery flag name
jimklimov added a commit to jimklimov/nut that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants