Fightwarn - unclassified fixes #858
Conversation
Seems this is a correct change logically: - if( !( SourceFail ) == RedeAnterior ) + if( RedeAnterior == !( SourceFail ) ) given this assignment just below the if-clause: RedeAnterior = !( SourceFail ); to avoid a compiler warning that "!" might apply not in a way intended by author
Avoids error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
hidparser.c:347:28: error: comparison is always false due to limited range of data type [-Werror=type-limits] 347 | if(pParser->Data.ReportID >= MAX_REPORT) uint8_t vs "500" CC @aquette
…the value to debug-log unexpectancies
| @@ -62,7 +62,6 @@ static nutscan_device_t * dev_ret = NULL; | |||
| #ifdef HAVE_PTHREAD | |||
| static pthread_mutex_t dev_mutex; | |||
| #endif | |||
| long g_usec_timeout ; | |||
There was a problem hiding this comment.
@aquette : was there any use or plan for this variable, or was it just some copy-paste artifact?
|
This pull request introduces 2 alerts when merging 8808f9d into 8c1ad08 - view on LGTM.com new alerts:
|
If we have some bug getting outlet numbers into billions (int at 64-bit) the string might overflow indeed...
|
This pull request introduces 3 alerts when merging 6e98a25 into 8c1ad08 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts and fixes 1 when merging 8e7f9d595f0115335962d94ed0c061e229cf731a into 8d2e761 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 1 when merging 7e7a433d0929c340a08f4a72a3b8ed00a53fd961 into 8d2e761 - view on LGTM.com new alerts:
fixed alerts:
|
jimklimov
force-pushed
the
fightwarn-unclassified-fixes
branch
from
7e7a433 to
1bc47ef
Compare
|
This pull request introduces 3 alerts when merging 1bc47ef into 26c8994 - view on LGTM.com new alerts:
|
Fixes to various small issues discovered thanks to CI improvements from #844