Fightwarn - macos llvm - noreturn #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
added
the
ready / code review
|
Error reports from clang were cut short by their reporting limits, some more "appeared" in view after the cleanup. PR would grow :) |
…h same-named func argument
… upsd.c and main.c) with func argument "progname"
…ribute__((...)) use-cases of interest to NUT
…warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
… warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…ifndef HAVE___ATTRIBUTE__NORETURN" to avoid warnings
…ifndef HAVE___ATTRIBUTE__NORETURN" to avoid warnings
…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…c "break;" after returns in conditionals
… compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now
…a legacy off-chance that fatalx() might not exit the program
…andle a legacy off-chance that fatalx() might not exit the program
…e handle a legacy off-chance that fatalx() might not exit the program
jimklimov
force-pushed
the
fightwarn-macos-llvm-noreturn
branch
from
46383fb to
7ce0e11
Compare
|
This pull request fixes 1 alert when merging 7ce0e11 into 709800c - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #823 and #844 to address warnings from clang10 on MacOS builds: pre-declare attributes for routines that
exit()so the compiler can optimize for no return path handling.