Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fightwarn - macos llvm - ssize_t for read()/write()/send() #883

Merged

Conversation

jimklimov
Copy link
Member

Routines for read() and write() or send() are defined with ssize_t wherever I found to look.

Builds on MacOS complained about bitness range mismatch of int and ssize_t so the chain of calls was modernized here.

Follows up from #823 and #844 efforts.

@jimklimov jimklimov force-pushed the fightwarn-lgtm-com-ssize_t branch from 31e62b5 to 3f3851e Compare November 17, 2020 23:45
@jimklimov jimklimov added need testing Code looks reasonable, but the feature would better be tested against hardware or OSes ready / code review Author (and CI) consider the PR worthy of human rewievers' time labels Nov 17, 2020
@jimklimov jimklimov changed the title Fightwarn - macos llvm - ssize t Fightwarn - macos llvm - ssize_t for read()/write()/send() Nov 20, 2020
@jimklimov
Copy link
Member Author

At least partially tested by connections (driver, upsd, upsc) to snmp-ups and usbhid-ups devices.

@jimklimov jimklimov merged commit 28012f0 into networkupstools:master Nov 27, 2020
@jimklimov jimklimov deleted the fightwarn-lgtm-com-ssize_t branch November 27, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need testing Code looks reasonable, but the feature would better be tested against hardware or OSes ready / code review Author (and CI) consider the PR worthy of human rewievers' time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant