Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Drop x64 testing on appveyor #47

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Conversation

OrkoHunter
Copy link
Contributor

Fixes #41

@ysitu
Copy link
Contributor

ysitu commented Jul 21, 2015

Please add a comment explaining why you need to do this and what it takes to reenable x64 testing.

@ysitu ysitu added this to the networkx-metis-1.0 milestone Jul 21, 2015
@OrkoHunter
Copy link
Contributor Author

First, the default install of msvc does not support 64-bit tools, nevertheless the compiler for x64 is always present in the system with VS express. So, setuptools cannot work with a 64-bit Python install. However it does work for the default 32-bit arch.

This is an unresolved bug related to building a python package with msvc on x64 Windows arch. https://bugs.python.org/issue7511

However, there are temporary fixes for the build to work. Here is one little bad method of doing it manually. However, there is a better way of the same. The reason vcvarsall.bat is complaining that it can't find x64 compilers even if they are correctly installed in the Visual Studio VC folder, is that the Paths set inside the file are wrong. One can change the Paths according to their drive and folder locations and the build should work just fine. Here is an example patch

Now, Over a CI (AppVeyor) environment, I think it's not easy enough to apply the no-robust fix to make the x64 builds run. Rather we stop testing them over CI. And also, it's not like that we are dropping any Python version, it's just an architecture.

@ysitu
Copy link
Contributor

ysitu commented Jul 21, 2015

Sorry for being vague. I meant a comment in appveyor.yml. Now that you have typed that up, you can add a line in the file to refer to this PR.

@OrkoHunter
Copy link
Contributor Author

No problem. I added couple lines in the file.

ysitu added a commit that referenced this pull request Jul 22, 2015
@ysitu ysitu merged commit 3809c16 into networkx:master Jul 22, 2015
@OrkoHunter OrkoHunter deleted the fix-appveyor branch July 27, 2015 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants