-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Actions worflow for continuous deployment #204
Conversation
name: Publish to PyPI | ||
|
||
on: | ||
release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this triggered when we tag a commit for release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is triggered when we create a release on GitHub. I thought this would be good to do since we can also add release notes along with a tag when creating a release on GitHub.
- name: Build package | ||
run: python -m build | ||
|
||
- name: Publish package to PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How can we provide the package version number? Is it auto-upgraded?
- Will this deploy for all commits made to the Main branch or only for tagged commits?
The ideal strategy would be to upload a package only for tagged commits so that we can group multiple features into one release. Let me know your thoughts.
Another nice to have step would be to notify the release in our slack group ezflow
using webhooks but it's not a high priority task. We can look into it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we'll have to manually update the version number in the last commit before creating a release on GitHub. However, I think it's possible to extend this workflow such that it takes the version number specified in the GitHub release tag and updates it for the package. I've opened a separate issue for this (#205).
This worflow will publish the package to PyPI every time a release is created on GitHub.