This repository has been archived by the owner on May 16, 2022. It is now read-only.
Small performance improvements #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pre-formatting the default tags as a string, saving an array allocation + Array.Copy - Always using StringBuilder over concatenation, this resulted in fewer allocations and higher performance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall about 10-20% reduction in memory allocated by simple metric calls (in my test it went from 630 bytes per call to 520) and a small improvement in overall speed (~5%), but the call to
Socket.Senddominates the time so it's hardly noticeable.I also added a .editorconfig to make it easier to collaborate on this project when you have different editor settings.