Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording fixes in prompt_examples.md #303

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

neubig
Copy link
Collaborator

@neubig neubig commented Aug 29, 2023

A few typo fixes in promp_examples.md.

  • "Question Answer" should be "Question Answering"
  • "Machine Reading" is a bit of an esoteric technical term, and can probably be removed.
  • "Japanese-to-Python" is simpler English.

A few typo fixes in promp_examples.md.

* "Question Answer" should be "Question Answering"
* "Machine Reading" is a bit of an esoteric technical term, and can probably be removed.
* "Japanese-to-Python" is simpler English.
@neubig neubig requested a review from zhaochenyang20 August 29, 2023 12:18
@neubig neubig merged commit e11144e into main Aug 29, 2023
@neubig neubig deleted the wording_fixes_in_prompt_examples branch August 29, 2023 12:38
neubig added a commit that referenced this pull request Aug 29, 2023
* Wording fixes in prompt_examples.md (#303)

A few typo fixes in promp_examples.md.

* "Question Answer" should be "Question Answering"
* "Machine Reading" is a bit of an esoteric technical term, and can probably be removed.
* "Japanese-to-Python" is simpler English.

* fix bug when sequnece max length is None

* lint

---------

Co-authored-by: zhaochen20 <[email protected]>
Co-authored-by: Graham Neubig <[email protected]>
neubig added a commit that referenced this pull request Aug 29, 2023
* Relax dependencies for the library

* Relax dependencies fix bug (#305)

* Wording fixes in prompt_examples.md (#303)

A few typo fixes in promp_examples.md.

* "Question Answer" should be "Question Answering"
* "Machine Reading" is a bit of an esoteric technical term, and can probably be removed.
* "Japanese-to-Python" is simpler English.

* fix bug when sequnece max length is None

* lint

---------

Co-authored-by: zhaochen20 <[email protected]>
Co-authored-by: Graham Neubig <[email protected]>

---------

Co-authored-by: Eren Chenyang Zhao <[email protected]>
Co-authored-by: zhaochen20 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants