-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIP]: Zeroshot Pipeline #1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great pending comments and getting a test model / files up
dsikka
force-pushed
the
pipeline_refactor
branch
from
July 13, 2023 15:39
02a1f2c
to
e34249e
Compare
dsikka
force-pushed
the
clip_zshot
branch
5 times, most recently
from
July 13, 2023 17:42
981bd2e
to
a06dd80
Compare
dsikka
force-pushed
the
clip_zshot
branch
2 times, most recently
from
July 18, 2023 14:25
a1c5c4a
to
651595c
Compare
@bfineran Rebased and updated as per PR comments. |
dsikka
requested review from
bfineran and
Satrat
and removed request for
KSGulin
July 21, 2023 19:00
FYI This has been tested/verified with models by MLR |
Updated with a README.md showing examples |
dbogunowicz
previously approved these changes
Jul 31, 2023
dbogunowicz
reviewed
Jul 31, 2023
dbogunowicz
previously approved these changes
Jul 31, 2023
bfineran
previously approved these changes
Jul 31, 2023
…ytest skips until model issues are resolved
update model loading Co-authored-by: dbogunowicz <[email protected]>
bfineran
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE: Pipeline has been tested with MLR's Zershot models. However, these are not yet available on sparsezoo.
Pipeline
refactor and uses the newBasePipeline
classCLIPVisualPipeline
,CLIPTextPipeline
andCLIPZeroShotPipeline
to run zero-shot classification.OpenCLIP
Testing
test_clip.py
Tested with MLR's models (on the following images):
basilica.jpg
buddy.jpeg
Produces the output: