-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextGeneration][Timer] text gen specific timings + improved timing tooling #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
reviewed
Jul 14, 2023
dbogunowicz
previously approved these changes
Jul 14, 2023
dbogunowicz
previously approved these changes
Jul 18, 2023
rahul-tuli
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending response to comments!
review suggestions LGTM |
Revert to using timer.time for `TOKEN_GENERATION` Remove finally clause from `contextmanagers` Address review comments from @rahul-tuli
rahul-tuli
force-pushed
the
text-gen-timings
branch
from
July 21, 2023 13:50
f7572f9
to
92b2fac
Compare
rahul-tuli
approved these changes
Jul 21, 2023
dbogunowicz
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds:
TimerManager
workflow forengine_forward
subtimingsengine_forward
is always called in a child thread for batch splitting, it will not have access to thecurrent
timer contextvartimer.py
new_timer_context
for thistimer.time
helper contextmanager; see docstring for usagetest_plan:
Manually for now - once we have more text gen pipeline tests, we can add assertions that the proper stages are generated in the timer manager:
Manager and stages: