-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Generation] Automatically benchmark in auto-regressive setting #1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending more testing from @dbogunowicz
Ran a quite exhaustive set of manual tests specified in #1083, all looking good. |
Just as a heads up, I'm making my benchmarking script depend on this PR so please let me know when you merge/if anything changes. Thanks for this utility @dbogunowicz it couldn't have come at a better time |
…e_length is passed
e2d19aa
to
709853d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more type annotation things but looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Damian
When benchmarking an LLM, assert that input_ids length is one, so that benchmarks emulate the correct data.
Manual Testing