-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Generation] Turn off the (currently) inefficient external KV cache logic when internal KV cache management enabled #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timize_update_kv_cache
…timize_update_kv_cache
rahul-tuli
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…hub.com/neuralmagic/deepsparse into feature/damian/optimize_update_kv_cache
bfineran
previously approved these changes
Aug 24, 2023
dbogunowicz
dismissed stale reviews from bfineran and rahul-tuli
August 24, 2023 13:17
The base branch was changed.
…hub.com/neuralmagic/deepsparse into feature/damian/optimize_update_kv_cache
rahul-tuli
previously approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(n+1)st time is the charm 🚀
bfineran
previously approved these changes
Aug 24, 2023
dbogunowicz
force-pushed
the
feature/damian/optimize_update_kv_cache
branch
2 times, most recently
from
August 25, 2023 07:58
227ebe0
to
519bf1b
Compare
Satrat
reviewed
Aug 28, 2023
Satrat
approved these changes
Aug 28, 2023
bfineran
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an external KV cache loop running in parallel to the internal KV cache logic (if enabled) does not make much sense.
This PR has been tested using our internal (modest) LLM testing harness.
In general, this PR roughly accelerates inference by 25%
Edit: confirmed by a more exhaustive investigation