-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Branch][LLM Testing] LLM Testing Suite #1227
Merged
dbogunowicz
merged 26 commits into
feature/damian/testing_sources_truth
from
feature/damian/new_tests
Sep 7, 2023
Merged
[Feature Branch][LLM Testing] LLM Testing Suite #1227
dbogunowicz
merged 26 commits into
feature/damian/testing_sources_truth
from
feature/damian/new_tests
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deepsparse into dbogunowicz-patch-1
…deepsparse into dbogunowicz-patch-1
…nto feature/damian/new_tests
dbogunowicz
changed the base branch from
main
to
feature/damian/testing_sources_truth
September 6, 2023 10:49
…ruth' into feature/damian/new_tests
bfineran
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great job with the inline comments
dbogunowicz
added a commit
that referenced
this pull request
Sep 7, 2023
* initial commit * finish creation of helper objects * Update tests/conftest.py * small refactor * [Feature Branch][LLM Testing] LLM Testing Suite (#1227) * Update README.md * Update src/deepsparse/yolov8/README.md * Update text_generation.py * quality * readability * all tests passing * added some full kv cache tests * initial commit * ready for review * Delete tests/deepsparse/transformers/pipelines/proposal_text_generation_tests.md
dbogunowicz
added a commit
that referenced
this pull request
Sep 13, 2023
* initial commit * initial commit * [Feature Branch][LLM Testing] Create GroundTruthSource objects (#1219) * initial commit * finish creation of helper objects * Update tests/conftest.py * small refactor * [Feature Branch][LLM Testing] LLM Testing Suite (#1227) * Update README.md * Update src/deepsparse/yolov8/README.md * Update text_generation.py * quality * readability * all tests passing * added some full kv cache tests * initial commit * ready for review * Delete tests/deepsparse/transformers/pipelines/proposal_text_generation_tests.md * fix tests * Dipika's comments plus adjusting the script to renamed variables * remove ORT ground truth * add OPT tests * rebase and disable tests in GHA * quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers the testing as outlined in the internal LLM testing doc. Note, not the full scope is covered here, but the scope required to reliably test the LLM pipelines.
Here is the outline of the introduced tests:
test_freeze_first_position
:test_ort_model
:test_ort_single_token_prefill
:test_ort_multi_token_prefill
:test_ort_generation_after_kv_cache_has_been_filled
:test_deepsparse_single_token_prefill
:test_deepsparse_multi_token_prefill
:test_deepsparse_generation_after_kv_cache_has_been_filled
:test_run_same_prompt_multiple_times
:_test_output
(a helper function):_test_kv_cache_state
(a helper function):Note: This PR assumes changes from #1198