[server] Disable the elastic scheduler when continuous batching is enabled #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
approved these changes
Jan 30, 2024
bfineran
approved these changes
Jan 31, 2024
dsikka
added a commit
that referenced
this pull request
Jan 31, 2024
…abled (#1569) * update server to disable the context/elastic scheduler when continuous batching is enabled * clean up when context is created
Merged
dsikka
added a commit
that referenced
this pull request
Feb 1, 2024
* [server] Disable the elastic scheduler when continuous batching is enabled (#1569) * update server to disable the context/elastic scheduler when continuous batching is enabled * clean up when context is created * [TextGeneration] Fix initialization; don't try v1 init for text gen (#1571) * only check capacity condition durin prefill; already have check in generation * dont try v1 if running text gen; just raise error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Contextobject as all pipelines used theMultiModelEnginewhich requires aContextinput.Contextalways uses theelasticschedulercontinuous_batch_sizesare provided, aContextobject is not used during pipeline initialization and a single stream scheduler is selected.MultiModelEnginefor this case but any other pipeline initialized withoutcontinuous_batch_sizeswill useContext/MultiModelEngine