Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextGeneration] Add helper function to parse model path from args #1583

Merged
merged 5 commits into from
Feb 7, 2024
Merged

[TextGeneration] Add helper function to parse model path from args #1583

merged 5 commits into from
Feb 7, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Feb 5, 2024

Summary

The following now works:

from deepsparse import TextGeneration
model_path = "hf:mgoin/TinyStories-1M-ds"

pipe = TextGeneration(model_path)

This still works:

model_path  = TextGeneration(model_path=model_path)

bfineran
bfineran previously approved these changes Feb 5, 2024
View reviewed changes
rahul-tuli
rahul-tuli reviewed Feb 5, 2024
View reviewed changes
src/deepsparse/pipeline.py Outdated Show resolved Hide resolved
src/deepsparse/pipeline.py Show resolved Hide resolved
@dsikka dsikka requested review from bfineran and rahul-tuli February 6, 2024 04:33
@dsikka dsikka merged commit c54461a into main Feb 7, 2024
13 checks passed
@dsikka dsikka deleted the update_create branch February 7, 2024 18:08
dsikka added a commit that referenced this pull request Feb 7, 2024
@dsikka
[TextGeneration] Add helper function to parse model path from args (#…
06e2233 
…1583)

* add helper function to parse model path from args

* update model path

* revert cli changes

* remove empty args
@dsikka dsikka mentioned this pull request Feb 7, 2024
Merged
bfineran pushed a commit that referenced this pull request Feb 7, 2024
@dsikka @bfineran
[TextGeneration] Add helper function to parse model path from args (#…
d1f08ce 
…1583)

* add helper function to parse model path from args

* update model path

* revert cli changes

* remove empty args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@mgoin mgoin mgoin approved these changes

@rahul-tuli rahul-tuli Awaiting requested review from rahul-tuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsikka @mgoin @bfineran @rahul-tuli