Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using system_logging_config directly instead of using Depends #858

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Using system_logging_config directly instead of using Depends #858

merged 1 commit into from
Jan 10, 2023

Conversation

corey-nm
Copy link
Contributor

@corey-nm corey-nm commented Jan 9, 2023 •
edited
Loading

To resolve issue of

  File "/home/ubuntu/workspace/Github/TestDeepsparse/runtests/lib/python3.8/site-packages/deepsparse/server/server.py", line 266, in _predict
    system_logging_config=params.get("system_logging_config"),
AttributeError: 'Depends' object has no attribute 'get'

Testing plan

Ran commands in yolo README.md

dbarbuzzi
dbarbuzzi approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@dbarbuzzi dbarbuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that these changes resolve the issue that was occurring when testing the YOLO server example within the src/deepsparse/yolo/README.md.

bfineran
bfineran approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively approving. @corey-nm do you know if there was a specific reason why Depends was needed? Otherwise would be good to check in with @dbogunowicz

@corey-nm
Copy link
Contributor Author

corey-nm commented Jan 9, 2023

Not sure, will wait on info from @dbogunowicz

@dbogunowicz
Copy link
Contributor

Taking a look.

@corey-nm corey-nm merged commit 8ed298f into main Jan 10, 2023
@corey-nm corey-nm deleted the fix-system-logging-config branch January 10, 2023 14:40
dbogunowicz pushed a commit that referenced this pull request Mar 22, 2023
@corey-nm @dbogunowicz
Using system_logging_config directly instead of using Depends (#858)
360c828
dbogunowicz pushed a commit that referenced this pull request Mar 22, 2023
@corey-nm @dbogunowicz
Using system_logging_config directly instead of using Depends (#858)
527979c
bfineran added a commit that referenced this pull request Mar 22, 2023
@dbogunowicz @corey-nm @bfineran
[Cherry Pick] Using system_logging_config directly instead of using D…
22208e5 
…epends (#858) (1.4.2) (#973)

* Using system_logging_config directly instead of using Depends (#858)

* Update version.py

---------

Co-authored-by: corey-nm <[email protected]>
Co-authored-by: Benjamin Fineran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@dbarbuzzi dbarbuzzi dbarbuzzi approved these changes

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corey-nm @dbogunowicz @dbarbuzzi @bfineran