Skip to content

Commit

Permalink
add job's project_name in pass_config data (#2081)
Browse files Browse the repository at this point in the history
  • Loading branch information
YevheniiSemendiak authored Apr 19, 2023
1 parent ba0b1dd commit 73c4d33
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion platform_api/orchestrator/jobs_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ async def _setup_pass_config(
cluster_name: str,
org_name: Optional[str],
job_request: JobRequest,
project_name: Optional[str] = None,
) -> JobRequest:
if NEURO_PASSED_CONFIG in job_request.container.env:
raise JobsServiceException(
Expand All @@ -206,6 +207,7 @@ async def _setup_pass_config(
"cluster": cluster_name,
"org_name": org_name,
"url": str(self._api_base_url),
"project_name": project_name,
}
).encode()
).decode()
Expand Down Expand Up @@ -291,7 +293,7 @@ async def create_job(

if pass_config:
job_request = await self._setup_pass_config(
user, cluster_name, org_name, job_request
user, cluster_name, org_name, job_request, project_name
)

record = JobRecord.create(
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_job_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ async def test_create_job_pass_config(
assert passed_data["token"] == f"token-{test_user.name}"
assert passed_data["cluster"] == original_job.cluster_name
assert passed_data["org_name"] == original_job.org_name
assert passed_data["project_name"] == original_job.project_name
token_uri = f"token://{original_job.cluster_name}/job/{original_job.id}"
assert mock_auth_client.grants[0] == (
test_user.name,
Expand Down

0 comments on commit 73c4d33

Please sign in to comment.