Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update pre-commit to work with latest hooks #259

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jan 18, 2024

For reviewer: thoughts on whether this should be a skip-release PR (won't end up in changelog) or a pr-dependencies (will end up in changelog)?

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the skip-release PR doesn't appear in the changelog and preserves current version when merged label Jan 18, 2024
@alyssadai alyssadai marked this pull request as ready for review January 18, 2024 19:45
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7575182172

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.771%

Totals Coverage Status
Change from base Build 7573557464: 0.0%
Covered Lines: 873
Relevant Lines: 875

💛 - Coveralls

@surchs surchs self-requested a review January 19, 2024 03:24
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

I vote for skip-release because it's just a dev-dependency. But no strong feelings on this.

@alyssadai alyssadai merged commit fb2de60 into main Jan 19, 2024
4 checks passed
@alyssadai alyssadai deleted the alyssadai-update-precommit branch January 19, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current pre-commit version no longer works with latest hooks
3 participants