Implement checks for unannotated categorical column values + unused annotated missing values #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the data dictionary - removed asst of test runner output to a variable for tests that don't use the result object
…e phenotypic file
Pull Request Test Coverage Report for Build 4686162992
💛 - Coveralls |
surchs
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Looks good to me @alyssadai! I think we should keep the tests a bit more loose with respect to the exact warning message we throw (left comments) so we keep them focused more on the functionality than the exact implementation.
I also left some 🍒 comments for you to consider.
surchs
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107, closes #109
Two new examples also added for testing, example 9 (.tsv has unannotated categorical column values) and 10 (.json has unused
"MissingValues"). Minor noticed typos also fixed.