Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent trailing slashes in routes #156

Closed
2 tasks done
alyssadai opened this issue Feb 7, 2025 · 1 comment · Fixed by #157
Closed
2 tasks done

Inconsistent trailing slashes in routes #156

alyssadai opened this issue Feb 7, 2025 · 1 comment · Fixed by #157
Assignees
@alyssadai
Labels
released This issue/pull request has been released. usability Issue affecting user or developer experience.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Feb 7, 2025 •
edited
Loading

Steps to implement

  • Ensure that all paths do not end in a trailing slash / for consistency

Housekeeping:

  • Rename environment variable for base path from NB_FAPI_ROOT_PATH -> NB_FAPI_BASE_PATH
@alyssadai alyssadai added the usability Issue affecting user or developer experience. label Feb 7, 2025
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 7, 2025
@surchs surchs moved this to Backlog in Neurobagel Feb 10, 2025
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 10, 2025
@alyssadai alyssadai moved this from Backlog to Specify - Active in Neurobagel Feb 11, 2025
@alyssadai alyssadai self-assigned this Feb 11, 2025
@alyssadai alyssadai moved this from Specify - Active to Specify - Done in Neurobagel Feb 11, 2025
@alyssadai alyssadai moved this from Specify - Done to Implement - Active in Neurobagel Feb 11, 2025
@alyssadai alyssadai mentioned this issue Feb 12, 2025
Merged
7 tasks
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Feb 12, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Feb 12, 2025
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 Issue was released in v0.4.4 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
released This issue/pull request has been released. usability Issue affecting user or developer experience.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MNT] Remove trailing slashes from all paths + rename NB_FAPI_ROOT_PATH neurobagel/federation-api
2 participants
@surchs @alyssadai