Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Split /attributes into attribute-specific resources #126

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 18, 2024

Changes proposed in this pull request:

  • /attributes router removed
    • GET /attributes/{data_element_uri} removed
  • Added two new routers:
    • /assessments
    • /diagnoses
  • Created factory function for the root / (i.e., get all instances in the graph) subpath of attribute-specific routers
  • Refactored /attribute endpoint tests and renamed test module to test_attribute_factory_routes.py
  • Created mapping of resource base paths to controlled terms for Neurobagel attributes, for easier parametrization

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) label Oct 18, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11410412738

Details

  • 53 of 53 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.856%

Totals Coverage Status
Change from base Build 11407359136: 0.1%
Covered Lines: 647
Relevant Lines: 668

💛 - Coveralls

@surchs surchs self-requested a review October 21, 2024 13:30
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai, looks good.

🧑‍🍳

@alyssadai alyssadai merged commit 14e2c53 into main Oct 21, 2024
5 checks passed
@alyssadai alyssadai deleted the refactor-attributes-router branch October 21, 2024 15:20
Copy link
Contributor

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Create dedicated endpoints for pipeline and diagnosis
3 participants