-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented new endpoint to return known node APIs #29
Conversation
Pull Request Test Coverage Report for Build 6906358008
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem! Nice regex use! I left a couple of suggestions with clarity in mind, take a look.
I do think that we should emit warnings if the LOCAL_NB_NODES
contains bad input. If that's a bigger deal to address, please make a separate issue to raise that warning so we don't forget
🚀 PR was released in |
Changes proposed in this pull request:
NB_NODES
as a string of strings to string of tuplesNB_NODES
toLOCAL_NB_NODES
parse_nodes_as_list
toparse_nodes_as_dict
get
function incrud.py
get_terms
function ofcrud.py
CohortQueryResponse
response_model
forget_query
endpointnodes
router and an endpoint to return all known node APIsChecklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: