Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Updated query-tool-results files #44

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[MNT] Updated query-tool-results files #44

merged 2 commits into from
Nov 20, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 19, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review November 20, 2024 15:54
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmanaem, the files look great, but as mentioned in neurobagel/query-tool#357 we should not put spaces in the file names. So please update the examples once the no-spaces fix is in, and then all good to go

@rmanaem rmanaem requested a review from surchs November 20, 2024 17:16
@surchs
Copy link
Contributor

surchs commented Nov 20, 2024

🧑‍🍳

@rmanaem rmanaem merged commit 66bbba1 into main Nov 20, 2024
@rmanaem rmanaem deleted the maint-43 branch November 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Tool response examples still include too many session instances
2 participants