-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Functions added to fetch the termURLs of diagnosis, assessment, sex and image modality #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Raya679!
🍒 Please see the comments.
Aside from those, I believe doing the termURL look up the way it is at the moment would require the user to know the exact wording of the term labels and therefore allows for no flexibility.
For example if a user input has a typo or if a user input uses an acronym for a term (MoCA or moca for Montreal Cognitive Assessment Tool) the look up fails to find the correct term and returns None.
I believe this is one of the most important steps of the project and we should leverage every tool to make term look up to be as flexible as possible. Let me know what you think.
Co-authored-by: Arman Jahanpour <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @Raya679!
I left one small comment other than that this is good to go 🧑🍳
Side note, how did you create the abbreviations?
Hi @rmanaem thanks for the review!! Regarding the abbreviations I had created them using llama3 itself similar to what was done in the annotation tool ai |
Changes proposed in this pull request:
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: