Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Functions added to fetch the termURLs of diagnosis, assessment, sex and image modality #20

Merged
merged 13 commits into from
Jul 25, 2024

Conversation

Raya679
Copy link
Contributor

@Raya679 Raya679 commented Jul 9, 2024

Changes proposed in this pull request:

  • Fetches the appropriate termURL of diagnosis and assessment tool from the respective api url.
  • Gets the appropriate termURL of sex and image modality from the hardcoded mappings.
  • Added tests for all the new functions.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@Raya679 Raya679 requested a review from rmanaem July 9, 2024 20:19
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Raya679!
🍒 Please see the comments.
Aside from those, I believe doing the termURL look up the way it is at the moment would require the user to know the exact wording of the term labels and therefore allows for no flexibility.
For example if a user input has a typo or if a user input uses an acronym for a term (MoCA or moca for Montreal Cognitive Assessment Tool) the look up fails to find the correct term and returns None.
I believe this is one of the most important steps of the project and we should leverage every tool to make term look up to be as flexible as possible. Let me know what you think.

app/LLM_extractions/extractions.py Outdated Show resolved Hide resolved
app/LLM_extractions/extractions.py Outdated Show resolved Hide resolved
app/LLM_extractions/extractions.py Show resolved Hide resolved
tests/test_get_termURLs.py Show resolved Hide resolved
tests/test_get_termURLs.py Show resolved Hide resolved
tests/test_get_termURLs.py Show resolved Hide resolved
@rmanaem rmanaem added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Jul 13, 2024
@Raya679 Raya679 requested a review from rmanaem July 22, 2024 18:41
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @Raya679!
I left one small comment other than that this is good to go 🧑‍🍳
Side note, how did you create the abbreviations?

app/LLM_extractions/extractions.py Outdated Show resolved Hide resolved
@Raya679
Copy link
Contributor Author

Raya679 commented Jul 25, 2024

Thanks for making the changes @Raya679! I left one small comment other than that this is good to go 🧑‍🍳 Side note, how did you create the abbreviations?

Hi @rmanaem thanks for the review!! Regarding the abbreviations I had created them using llama3 itself similar to what was done in the annotation tool ai

@Raya679 Raya679 merged commit f0ae536 into main Jul 25, 2024
3 checks passed
@Raya679 Raya679 deleted the fetch_termURL branch July 25, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve Appropriate term url for Diagnosis, Assessment Tools, Sex and Image modality
2 participants