Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Set up continuous integration workflows #22

Merged
merged 3 commits into from
Jul 15, 2024
Merged

[MNT] Set up continuous integration workflows #22

merged 3 commits into from
Jul 15, 2024

Conversation

Raya679
Copy link
Contributor

@Raya679 Raya679 commented Jul 13, 2024 •
edited by rmanaem
Loading

Changes proposed in this pull request:

  • Added GitHub Actions workflows for linting and testing the codebase using flake8 and pytest.
  • Also added steps to install Ollama and pull the Mistral model in the workflow to ensure the model is available for running tests.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@Raya679 Raya679 requested a review from rmanaem July 13, 2024 19:21
@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Jul 15, 2024
rmanaem
rmanaem approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR @Raya679! This is good to go 🧑‍🍳

@Raya679 Raya679 merged commit c0348b0 into main Jul 15, 2024
3 checks passed
@Raya679 Raya679 deleted the workflow branch July 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up continuous integration workflows
2 participants
@Raya679 @rmanaem