Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] FastAPI integration added #31

Merged
merged 11 commits into from
Aug 8, 2024
Merged

[ENH] FastAPI integration added #31

merged 11 commits into from
Aug 8, 2024

Conversation

Raya679
Copy link
Contributor

@Raya679 Raya679 commented Aug 4, 2024

Changes proposed in this pull request:

  • FastAPI integration added.
  • Dockerized the code which has FastAPI integrated.
  • Updated the readme.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@Raya679
Copy link
Contributor Author

Raya679 commented Aug 5, 2024

Hi @rmanaem,
I have added the fastAPI integration here. Please do suggest any changes if required.

@rmanaem rmanaem self-requested a review August 5, 2024 16:36
@rmanaem rmanaem added the pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) label Aug 5, 2024
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Raya679!
Aside from the inline comments and suggested changes, I think we should make the base_api_url an environment variable so please open an issue to address this in a separate PR.

app/router/routes.py Outdated Show resolved Hide resolved
app/router/routes.py Outdated Show resolved Hide resolved
app/main.py Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Raya679 and others added 4 commits August 6, 2024 17:28
@Raya679
Copy link
Contributor Author

Raya679 commented Aug 7, 2024

Hii @rmanaem,
I have made the required changes. Please do suggest any changes if required.
Also currently I am working on this issue to make base_api_url an environment variable.
Also regarding the import errors I have made a new issue which I will be addressing once this PR is merged.

Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @Raya679!
I left two comments, please take a look.

README.md Outdated Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
@Raya679
Copy link
Contributor Author

Raya679 commented Aug 7, 2024

Hii @rmanaem,
I have made the required changes. Please do suggest any changes if required.
Thanks!!

Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion and then good to go 🧑‍🍳

README.md Outdated Show resolved Hide resolved
@Raya679 Raya679 merged commit bce1459 into main Aug 8, 2024
4 checks passed
@Raya679 Raya679 deleted the fastAPI-integration branch August 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAPI Integration
2 participants