Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read about changes required to make UI responsive #333

Closed
1 of 3 tasks
surchs opened this issue Oct 28, 2024 · 5 comments · Fixed by #339
Closed
1 of 3 tasks

Read about changes required to make UI responsive #333

surchs opened this issue Oct 28, 2024 · 5 comments · Fixed by #339
Assignees
Labels
phase:research involves researching information on a topic rather than implementing specific feature. released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented Oct 28, 2024

The goal is to find tools/ways/best practices to modify the existing UI so that elements are reasonably spaced and do not overlap when screen size changes.

A good starting point for research would be to take a look at the material design docs on responsive layout: https://m2.material.io/design/layout/responsive-layout-grid.html#columns-gutters-and-margins

@surchs surchs added the phase:research involves researching information on a topic rather than implementing specific feature. label Oct 28, 2024
@surchs surchs moved this to Backlog in Neurobagel Oct 28, 2024
@rmanaem rmanaem self-assigned this Oct 30, 2024
@rmanaem rmanaem moved this from Backlog to Implement - Active in Neurobagel Oct 30, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Oct 30, 2024

A good starting point for research would be to take a look at the material design docs on responsive layout: https://m2.material.io/design/layout/responsive-layout-grid.html#columns-gutters-and-margins

This unfortunately wasn't practical as it essentially documented how material design approaches responsive layout grid as opposed to how a developer can use existing properties, components, and classes to implement a responsive UI.

@surchs
Copy link
Contributor Author

surchs commented Oct 30, 2024

@rmanaem can you say why it wasn't practical, so we don't try it again next time just to learn the same thing twice

@surchs
Copy link
Contributor Author

surchs commented Oct 30, 2024

I also think it'd be good to expand the issue description to list some questions / things you have/will review here and what behaviour we want solutions for. The list in #122 should be a good source of things to get answers for

@rmanaem
Copy link
Contributor

rmanaem commented Oct 30, 2024

I also think it'd be good to expand the issue description to list some questions / things you have/will review here and what behaviour we want solutions for. The list in #122 should be a good source of things to get answers

Yea, let's use the list in the parent issue as the source and not duplicate it here.

@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Nov 3, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 5, 2024
Copy link
Contributor

neurobagel-bot bot commented Nov 5, 2024

🚀 Issue was released in v0.6.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
phase:research involves researching information on a topic rather than implementing specific feature. released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants