Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Made UI responsive for smaller screens #339

Merged
merged 18 commits into from
Nov 5, 2024
Merged

[ENH] Made UI responsive for smaller screens #339

merged 18 commits into from
Nov 5, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 3, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass
  • If the PR changes the participant-level and/or the dataset-level result file, the query-tool-results files in the neurobagel_examples repo have been regenerated

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) release Create a release when this PR is merged labels Nov 3, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 3, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 4585814
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/672a64ec2c9a3900080f5754
😎 Deploy Preview https://deploy-preview-339--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review November 4, 2024 18:46
surchs
surchs approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmanaem, thanks for the work on this PR!

🧑‍🍳

cypress/component/ResultCard.cy.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
src/components/Navbar.tsx Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
@rmanaem rmanaem merged commit d60f970 into main Nov 5, 2024
9 checks passed
@rmanaem rmanaem deleted the responsive-ui branch November 5, 2024 18:45
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Nov 5, 2024

🚀 PR was released in v0.6.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read about changes required to make UI responsive Make UI responsive for smaller screens
2 participants
@rmanaem @surchs