Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Always prompt login if auth is enabled #277

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[FIX] Always prompt login if auth is enabled #277

merged 2 commits into from
Sep 12, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Sep 12, 2024

Fixes #276

  • Closes #

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 4dc5f2d
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/66e354a22773e400088175a3
😎 Deploy Preview https://deploy-preview-277--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Sep 12, 2024
@surchs
[REF] Let tests handle the auth dialogue
4dc5f2d 
Needs to be closed first, so it doesn't cover UI elements
@surchs surchs enabled auto-merge (squash) September 12, 2024 20:54
@surchs surchs disabled auto-merge September 12, 2024 20:55
@surchs surchs merged commit 57409d3 into main Sep 12, 2024
9 checks passed
@surchs surchs deleted the always_prompt_login branch September 12, 2024 20:55
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 PR was released in v0.5.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable login prompt on enigma-query demo
1 participant
@surchs