Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make this a pip package that is sklearn API compliant #1

Open
jovo opened this issue Jun 5, 2020 · 3 comments
Open

make this a pip package that is sklearn API compliant #1

jovo opened this issue Jun 5, 2020 · 3 comments
Assignees
Labels
sklearn will try to merge into sklearn

Comments

@jovo
Copy link
Member

jovo commented Jun 5, 2020

this probably means making the experiments into 'examples'

@jovo jovo added the sklearn will try to merge into sklearn label Aug 9, 2020
jdey4 pushed a commit that referenced this issue Sep 18, 2020
levinwil pushed a commit that referenced this issue Sep 22, 2020
Getting updates from progressive-learning
levinwil pushed a commit that referenced this issue Sep 29, 2020
@levinwil
Copy link
Collaborator

@jovo could you please provide further instructions? I don’t think we can make any of the progressive learners fit an Sklearn API (besides UF, if you consider that a progressive learner), but we have converted all Transformers, Voters, and Deciders to fit all the Sklearn APIs we thought were appropriate. Do you have further expectations and/or hopes as far as Sklearn API compliance goes?

@jovo
Copy link
Member Author

jovo commented Oct 15, 2020

@bdpedigo @sampan501 do you guys have the link that explains how to check this?

@sampan501
Copy link
Member

At the very least, all functions should inherit from the base classes. A more comprehensive tutorial can be found here. The tl;dr for the last guide is that it needs to pass check_estimator. I would add a unit test for this for each function.

levinwil pushed a commit that referenced this issue Oct 21, 2020
levinwil pushed a commit that referenced this issue Oct 27, 2020
PSSF23 pushed a commit that referenced this issue Dec 12, 2020
PSSF23 pushed a commit that referenced this issue Feb 9, 2021
Pulled updates from Staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sklearn will try to merge into sklearn
Projects
None yet
Development

No branches or pull requests

4 participants