Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirements redundancy and include package versions #320

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Remove requirements redundancy and include package versions #320

merged 2 commits into from
Oct 17, 2020

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Oct 17, 2020

Reference issue

close #265 @jdey4 @levinwil

Type of change

Documentation

What does this implement/fix?

Remove the simplified requirement list from setup.py and let it read from requirements.txt.

Additional information

  • requires.txt generated in proglearn.egg-info was the same as requirements.txt
  • Tested in an empty virtual environment and pip install proglearn command showed all requirements satisfied.
  • pip list command screenshots before and after:

Screen Shot 2020-10-17 at 15 04 34

Screen Shot 2020-10-17 at 14 59 37

levinwil
levinwil approved these changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@levinwil levinwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I appreciate the initiative!

@levinwil levinwil merged commit f663fef into neurodata:staging Oct 17, 2020
@levinwil levinwil mentioned this pull request Oct 17, 2020
Closed
@PSSF23 PSSF23 deleted the trust_in_you branch October 17, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levinwil levinwil levinwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PSSF23 @levinwil