Fix {network, forest}.py default overloading #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a parameter to add_task as n_estimtaors? I need that for the experiments. I did this in a branch that has now merge conflicts. |
|
@jdey4 Ya sure but I'll do that in another PR. That way, each PR addresses one and only one fix. |
|
@jdey4 Can you please submit a feature request issue for that, so I remember to do so? |
levinwil
changed the title
jdey4
approved these changes
Oct 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes Issue #322
Type of change
Bug
What does this implement/fix?
Previously, we used None to instruct the usage of default parameters when calling 'add_{task, transformer}'. But, this has undesirable effects, such as the inability to add a new forest which trains to purity (unless the default value for the LLCF is None, which is not all the time). As such, we now use the string 'default' to indicate the usage of default parameters.
Additional information