Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XOR_RXOR Tutorial completed #369

Merged
merged 6 commits into from
Nov 17, 2020
Merged

XOR_RXOR Tutorial completed #369

merged 6 commits into from
Nov 17, 2020

Conversation

bstraus1
Copy link
Contributor

Reference issue

Closes #330

Type of change

Documentation

What does this implement/fix?

Completed and added the xor_rxor tutorial and associated functions file.

@bstraus1
Copy link
Contributor Author

@levinwil Will you please link this to issue #330.

@levinwil levinwil linked an issue Nov 17, 2020 that may be closed by this pull request
2 tasks
@levinwil
Copy link
Collaborator

@bstraus1 Done.

@levinwil
Copy link
Collaborator

@bstraus1 Please add this tutorial to the netlify docs folder tutorials rst file. See #365 for instructions.

@bstraus1
Copy link
Contributor Author

@levinwil Done

@levinwil
Copy link
Collaborator

  1. Match the naming convention of the N-XOR tutorial in the docs and headers
  2. Fix the latex equations to render correctly in netlify.

You should just follow the N-XOR tutorial and make a slight modification in that of the rotation angle, the text description, and nothing else.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #356, maybe make a shorter title (it will show up in Netlify menu) and remove the blank cell at the end?

@bstraus1
Copy link
Contributor Author

@PSSF23 @levinwil How do I see the netlify view so I know what to change?

@levinwil
Copy link
Collaborator

@bstraus1 As mentioned, see #365 for instructions on how to view netlify. Go to the checks and go to the netlify checks then click on "details" on the right.

@bstraus1
Copy link
Contributor Author

@levinwil Will do. Just note that #365 was not mentioned until you mentioned it. It is very helpful.

@bstraus1
Copy link
Contributor Author

@levinwil Alright, I think it's better now.

@PSSF23
Copy link
Member

PSSF23 commented Nov 17, 2020

@bstraus1 please fix x-axis for last graph & remove empty cell.

@bstraus1
Copy link
Contributor Author

@PSSF23 Done 😃

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a small typo~ Will merge after tests.

@PSSF23 PSSF23 merged commit bd232b0 into neurodata:staging Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create xor-rxor tutorial notebook using Jayanta's code
3 participants