Further adjust bash syntax; reduce workflow steps

neurogenomics · Dec 10, 2023 · 93b6e22 · 93b6e22
1 parent 634ce1e
commit 93b6e22
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/rworkflows.yml b/.github/workflows/rworkflows.yml
@@ -46,13 +46,11 @@ jobs:
         run_covr: ${{ true }}
         run_pkgdown: ${{ true }}
         has_runit: ${{ false }}
-        has_latex: ${{ true }}
+        # has_latex: ${{ true }}
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run_docker: ${{ true }}
-        docker_user: bschilder
-        docker_org: neurogenomicslab
         DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN }}
         runner_os: ${{ runner.os }}
         cache_version: cache-v1
-        free_diskspace: ${{ true }}
-        miniforge_variant: false
+        # free_diskspace: ${{ true }}
+        # miniforge_variant: false
diff --git a/action.yml b/action.yml
@@ -453,7 +453,7 @@ runs:
     - name: ℹ️ Get R package info 
       if: runner.os == 'Linux'
       run: |
-        #### DockerHub repos must be lowercase (,,) ####
+        #### Docker repos must be lowercase (,,) ####
         name=$(grep '^Package:' DESCRIPTION | cut -d\   -f2)
         echo "packageName=${name,,}" >> $GITHUB_ENV
         echo "packageNameOrig=${name}" >> $GITHUB_ENV
@@ -463,15 +463,14 @@ runs:
         echo $version
         echo "BASE_IMAGE=${{ matrix.config.cont }}" >> $GITHUB_ENV
         #### Adjust docker args depending on docker_registry ####
-        if ${{ inputs.docker_registry }}=="docker.io"; 
-        then
-          echo "dockerOrg=${ inputs.docker_org,, }" >> $GITHUB_ENV
-          echo "dockerUser=${ inputs.docker_user }" >> $GITHUB_ENV
-          echo "dockerPass=${ inputs.DOCKER_TOKEN }" >> $GITHUB_ENV
+        if [[ "$inputs.docker_registry" != "docker.io" ]]; then
+          echo "dockerOrg=${inputs.docker_org,,}" >> $GITHUB_ENV
+          echo "dockerUser=${inputs.docker_user}" >> $GITHUB_ENV
+          echo "dockerPass=${inputs.DOCKER_TOKEN}" >> $GITHUB_ENV
         else
-          echo "dockerOrg=${ github.repository_owner,, }" >> $GITHUB_ENV
-          echo "dockerUser=${ github.repository_owner }" >> $GITHUB_ENV
-          echo "dockerPass=${ inputs.GITHUB_TOKEN }" >> $GITHUB_ENV
+          echo "dockerOrg=${github.repository_owner,,}" >> $GITHUB_ENV
+          echo "dockerUser=${github.repository_owner}" >> $GITHUB_ENV
+          echo "dockerPass=${inputs.GITHUB_TOKEN}" >> $GITHUB_ENV
         fi
       shell: bash {0}