Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
propagate=False
to any created name logger. Due to the insane way that python's logging module works it means that messages are printed tostdout
even iflog_to_console=False
.This is because, as I understand it, all named loggers are created with
root
as their 'parent'. By default all child logger messages are propagated to their parent handlers. Therefore if the root logger is used, aStreamHandler
is set on it and then the named logger starts logging to console. For example a MRE:The tests are currently failing due to an issue with handlers that will be addressed in #33.