-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial polar coordinates #180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 11 11
Lines 638 638
=======================================
Hits 636 636
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @sfmig 🎉!
This looks good, I just had a few clarifying questions and some optional suggestions.
Also, two thoughts came to mind:
- @b-peri is working on implementing head direction as a derived variable. Once we have that, we should edit the first half of this example to use our implementation.
- In your examples, you go at great lengths to produce detailed and informative plots, but this take lots of matplotlib code. Perhaps we should wrap the most useful such plots as
movement.plot
utilities, for our (and the users) convenience. Trajectory is the obvious one here. To be clear, this is feature idea for the future (not for this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @sfmig !!
I'm very happy with how this looks now, just two minor comments, and after that ready to merge.
Quality Gate passedIssues Measures |
Description
What is this PR
Why is this PR needed?
We wanted to add a tutorial with an example use of polar coordinates.
What does this PR do?
\
References
Closes #160
How has this PR been tested?
The docs build locally and on CI
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: