Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Python versions #208

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Update supported Python versions #208

merged 4 commits into from
Jun 6, 2024

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Jun 5, 2024

Following Scientific Python's SPEC-0, we are dropping support for python v3.9 and adding support for python v3.12.
In the installation instructions, the recommended python version for the conda environment was bumped from 3.10 to 3.11, and consequently 3.11 is also the version we test across all OSes in CI.

One of the ruff linters (pyupgrade) automatically replaced all Union occurrences with the | syntax, because that was introduced in 3.10.

I also added a badge to the README, which will automatically fetch supported Python version from PyPI and display them.

Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (53a9eff) to head (e0865cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files          11       11              
  Lines         634      633       -1     
==========================================
- Hits          632      631       -1     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi marked this pull request as ready for review June 5, 2024 16:54
@niksirbi niksirbi requested a review from lochhh June 5, 2024 16:54
Copy link
Collaborator

@lochhh lochhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lochhh lochhh added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 52ac099 Jun 6, 2024
27 checks passed
@niksirbi niksirbi deleted the bump-python-versions branch June 6, 2024 09:05
@niksirbi niksirbi mentioned this pull request Jun 7, 2024
niksirbi added a commit that referenced this pull request Jun 13, 2024
Since [PR208](#208), python v3.11 is the main version we test across OSes and it's the one we recommend in the installation guide. But I'd forgotten to update the python version in the quick install section of the README. This PR rectifies that.
github-merge-queue bot pushed a commit that referenced this pull request Jun 14, 2024
Since [PR208](#208), python v3.11 is the main version we test across OSes and it's the one we recommend in the installation guide. But I'd forgotten to update the python version in the quick install section of the README. This PR rectifies that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants