Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sed cross-platform #48

Merged
merged 1 commit into from
Jul 31, 2022
Merged

make sed cross-platform #48

merged 1 commit into from
Jul 31, 2022

Conversation

alexsavulescu
Copy link
Member

closes #44

@alexsavulescu
Copy link
Member Author

Full-run here: https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/2762190051

nrnhines
nrnhines approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space in -i'bak' is certainly unexpected (when reading man or seeing the usage

usage: sed script [-Ealnru] [-i extension] [file ...]

)
but since it works...

@alexsavulescu
Copy link
Member Author

Tried different combinations, in the end this worked for me. x-ref: https://stackoverflow.com/a/14813278

@nrnhines nrnhines merged commit 4c286c0 into master Jul 31, 2022
@alexsavulescu alexsavulescu deleted the cross-platform-sed branch July 31, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

@kotsaloscv kotsaloscv Awaiting requested review from kotsaloscv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modeldb-run.yaml: sed -i is not portable
2 participants
@alexsavulescu @nrnhines