-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS fixes, model curation, etc. #76
Conversation
* 51781: fix on macOS, use consistent seed * 97756: don't print the time * 97868: fix curation regex for macOS * 97917: avoid building at runtime * 229276: encoding errors (macOS-specific?), reduce tstop * 267067: choose one of the two models inside, tune it a bit * 267384: avoid building at runtime
Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/4281622878 with all models. |
c14cb5d
to
5ce33a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5ce33a7
to
09141d8
Compare
Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/4282403327 with b5ca035 and all models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, already discussed these offline
This doesn't yet show a trivial diff, but I will merge this PR as it is already approved/reviewed and is a step in the right direction. |
--virtual
on macOSnrnivmodl