Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS fixes, model curation, etc. #76

Merged
merged 8 commits into from
Feb 27, 2023
Merged

macOS fixes, model curation, etc. #76

merged 8 commits into from
Feb 27, 2023

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Feb 27, 2023

  • fix --virtual on macOS
  • support fetching models from forked repositories on GitHub
  • disable build parallelism internal to nrnivmodl
  • do some more model curation

* 51781: fix on macOS, use consistent seed
* 97756: don't print the time
* 97868: fix curation regex for macOS
* 97917: avoid building at runtime
* 229276: encoding errors (macOS-specific?), reduce tstop
* 267067: choose one of the two models inside, tune it a bit
* 267384: avoid building at runtime
@olupton
Copy link
Collaborator Author

olupton commented Feb 27, 2023

@olupton olupton force-pushed the olupton/tuning branch 2 times, most recently from c14cb5d to 5ce33a7 Compare February 27, 2023 11:11
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modeldb/modeldb-run.yaml Outdated Show resolved Hide resolved
modeldb/modelrun.py Show resolved Hide resolved
modeldb/modeldb-run.yaml Show resolved Hide resolved
@olupton
Copy link
Collaborator Author

olupton commented Feb 27, 2023

Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already discussed these offline

@olupton
Copy link
Collaborator Author

olupton commented Feb 27, 2023

Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/4282403327 with b5ca035 and all models.

This doesn't yet show a trivial diff, but I will merge this PR as it is already approved/reviewed and is a step in the right direction.

@olupton olupton merged commit 39d62c9 into master Feb 27, 2023
@olupton olupton deleted the olupton/tuning branch February 27, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants