Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue for diam. #2913

Closed
1uc opened this issue Jun 13, 2024 · 0 comments
Closed

Performance issue for diam. #2913

1uc opened this issue Jun 13, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Jun 13, 2024

If I understand parts of #2787 correctly, one problem is related to the use of diam. I've looked at the generated code and see:

#define diam          *_ppvar[0].get<double*>()

which would cause each access to dereference the generic_data_handle, which we've seen in #2886 to cause performance issues.

My understanding is that diam is a dparam, and therefore semantically one double* per instance. Slight quirk, I think it's into the MORPHOLOGY "mechanism" which is special. However, it's still a double* per instance and therefore it should be part of neuron::cache::Model.

The purpose of this issue is simply to extract a solvable chunk of #2787.

pramodk pushed a commit that referenced this issue Jun 21, 2024
Optimizes nocmodl generated code to use the mechanism cache when
accessing diam and area as described in #2913.
@1uc 1uc closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant