Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backtrace information to signal handlers #733

Closed
ohm314 opened this issue Sep 4, 2020 · 0 comments
Closed

Add backtrace information to signal handlers #733

ohm314 opened this issue Sep 4, 2020 · 0 comments
Assignees
@ohm314
Labels
enhancement

Comments

@ohm314
Copy link
Member

ohm314 commented Sep 4, 2020

Neuron implements signal handlers in oc/hoc.c to handle SIGINT, SIGFPE, SIGSEGV and SIGBUS. The signal handlers produce a core dump and abort. Additionally it would be useful to print the stack trace to help the user/programmer to quickly find the offending code.
@ohm314 ohm314 self-assigned this Sep 4, 2020
ohm314 added a commit that referenced this issue Oct 20, 2020
@ohm314
Removed homegrown code
40b3c35 
Using backward-cpp we get proper backtraces on mac and backtraces+src on
linux. This fulfills #733 (but with the dependency on a new submodule)
@ohm314 ohm314 mentioned this issue Oct 20, 2020
Merged
@ohm314 ohm314 closed this as completed in 5d9de72 Oct 29, 2020
olupton added a commit that referenced this issue Dec 7, 2022
@olupton
Fix NMODL compilation when clang-format was found. (#733)
61928b1 
Without this fix then building
NMODL-as-a-submodule-of-CoreNEURON-as-a-submodule-of-NEURON would not
work if code formatting was enabled in NEURON following the recipe of
#1460. This was apparently
because NMODL was formatting NMODL generated code using a clang-format
configuration file from NEURON, which uses C++03 compatibility. This
breaks NMODL code compilation by adding a space before `_format` in
`"..{}.."_format("bar")`, which is not valid.

Also change the handling of the --clang-format-opts option so that the
${NMODL_ClangFormat_OPTIONS} option should actually work. Previously the
CMake code would generate something like:
  --clang-format-opts A B --clang-format-opts="--style=file"
where the `A B` part would then be ignored.

Update hpc-coding-conventions submodule commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohm314 ohm314

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ohm314